Run Messaging CI on Xcode 15

[paulb777]

Run FirebaseMessaging CI on Xcode 15.0.1 along with some changes:

• Add SPM visionOS testing for Messaging and Storage
• Defer Messaging integration tests on Xcode 15 pending PubSub test integration test failures
• Only run unit tests via pod_lib_lint instead of doubling up in the messaging job
• Rename messaging job to indicate that it is only to run the integration tests
• Run all SPM platform tests in non-cron
• Test --use-static-frameworks in cron instead of deprecated --use-modular-headers
• Restore Storage cron
• Move Storage integration tests back to Xcode 14 because of flakiness

#no-changelog

[google-oss-bot]

Coverage Report ¹

Affected Products

• FirebaseMessaging-iOS-FirebaseMessaging.framework

  Overall coverage changed from 60.67% (24be340) to 60.56% (24bffb0) by -0.11%.

  Filename	Base (24be340)	Merge (24bffb0)	Diff
  FIRMessagingCheckinPreferences.m	98.02%	93.07%	-4.95%
  FIRMessagingPendingTopicsList.m	90.59%	89.80%	-0.78%

Test Logs

• Base (24be340): https://github.com/firebase/firebase-ios-sdk/actions/runs/6713319025
• Merge (24bffb0): https://github.com/firebase/firebase-ios-sdk/actions/runs/6720377864

1. https://storage.googleapis.com/firebase-sdk-metric-reports/1LEer18DOr.html

[paulb777]

Consistently getting this integration test failure with Xcode 15.0.1:

FIRMessagingPubSubTest
    ✗ testSubscribeTopic, XCTAssertNil failed: "Error Domain=com.google.fcm Code=0 "Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field." UserInfo={NSLocalizedFailureReason=Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field.}"
    ✗ testUnsubscribeTopic, XCTAssertNil failed: "Error Domain=com.google.fcm Code=0 "Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field." UserInfo={NSLocalizedFailureReason=Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field.}"
FIRMessagingTokenRefreshTests
    ✓ testDeleteDataWithTokenRefreshDelegatesAndNotifications (1.587 seconds)
    ✓ testDeleteDefaultTokenWithTokenRefreshDelegatesAndNotifications (0.518 seconds)
    ✓ testDeleteTokenWithTokenRefreshDelegatesAndNotifications (1.053 seconds)


FirebaseMessaging_Unit_integration.FIRMessagingPubSubTest
  testSubscribeTopic, XCTAssertNil failed: "Error Domain=com.google.fcm Code=0 "Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field." UserInfo={NSLocalizedFailureReason=Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field.}"
  /Users/runner/work/firebase-ios-sdk/firebase-ios-sdk/FirebaseMessaging/Tests/IntegrationTests/FIRMessagingPubSubTest.swift:52

  messaging.subscribe(toTopic: "cat_video") { error in
    XCTAssertNil(error)
    expectation.fulfill()

testUnsubscribeTopic, XCTAssertNil failed: "Error Domain=com.google.fcm Code=0 "Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field." UserInfo={NSLocalizedFailureReason=Invalid registration response :'Error=INTERNAL_SERVER_ERROR'. It is missing 'token' field.}"
/Users/runner/work/firebase-ios-sdk/firebase-ios-sdk/FirebaseMessaging/Tests/IntegrationTests/FIRMessagingPubSubTest.swift:63

  messaging.unsubscribe(fromTopic: "cat_video") { error in
    XCTAssertNil(error)
    expectation.fulfill()

   Executed 5 tests, with 2 failures (0 unexpected) in 28.335 (28.394) seconds
2023-10-31 23:47:22.212 xcodebuild[14521:81384] [MT] IDETestOperationsObserverDebug: 898.275 elapsed -- Testing started completed.
2023-10-31 23:47:22.212 xcodebuild[14521:81384] [MT] IDETestOperationsObserverDebug: 0.000 sec, +0.000 sec -- start
2023-10-31 23:47:22.212 xcodebuild[14521:81384] [MT] IDETestOperationsObserverDebug: 898.275 sec, +898.275 sec -- end
Failing tests:
  FIRMessagingPubSubTest.testSubscribeTopic()
  FIRMessagingPubSubTest.testUnsubscribeTopic()

** TEST FAILED **

[ncooke3]

Only run unit tests via pod_lib_lint instead of doubling up in the messaging job

Do you think this is something we should extend to other products as well?

[ncooke3]

great work, the runs-on: ${{ matrix.os }} is super useful!

[paulb777]

Only run unit tests via pod_lib_lint instead of doubling up in the messaging job

Do you think this is something we should extend to other products as well?

In most cases, we don't. I'll review as I work through the Xcode 15 changes.

[paulb777]

@andrewheard verified in #12035 that the visionOS changes don't work. I'll remove in a subsequent PR