Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Xcode 15 CI #12042

Merged
merged 11 commits into from
Nov 3, 2023
Merged

More Xcode 15 CI #12042

merged 11 commits into from
Nov 3, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 2, 2023

Add Xcode 15 to pod lib lint and spm CI for functions, fiam, installations, mlmodeldownloader, performance, remoteconfig, sessions, shared-swift and spm.

I disabled some tests on Xcode 15 because of iOS simulator flakiness and will monitor upcoming nightlies for the need to do more.

Also, fixed a nullability issue in a FIAM internal API and a FIAM unit test failure triggered by the recent changes in handling URL strings.

I disabled a Performance unit test that failed on SPM in addition to the several more that were already disabled for SPM. See #11903

#no-changelog

@google-oss-bot
Copy link

google-oss-bot commented Nov 3, 2023

Coverage Report 1

Affected Products

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.56% (fa7ca72) to 60.59% (1106397) by +0.03%.

    FilenameBase (fa7ca72)Merge (1106397)Diff
    FIRMessagingAnalytics.m80.00%82.14%+2.14%
    FIRMessagingCheckinPreferences.m98.02%93.07%-4.95%
    FIRMessagingPendingTopicsList.m89.02%90.59%+1.57%
  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.71% (fa7ca72) to 94.74% (1106397) by +0.03%.

    FilenameBase (fa7ca72)Merge (1106397)Diff
    FPRNetworkTrace.m95.25%95.85%+0.59%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nLwgukaWIF.html

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul!

.github/workflows/firebasepod.yml Show resolved Hide resolved
.github/workflows/spm.yml Show resolved Hide resolved
@paulb777 paulb777 merged commit aec227b into master Nov 3, 2023
224 checks passed
@paulb777 paulb777 deleted the pb-more-more-xcode15-ci branch November 3, 2023 18:36
@firebase firebase locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants