Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Stop Xcode 14, start Xcode 15.3 #12746

Merged
merged 11 commits into from
Apr 12, 2024
Merged

[CI] Stop Xcode 14, start Xcode 15.3 #12746

merged 11 commits into from
Apr 12, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 10, 2024

TODOs:

@google-oss-bot
Copy link

google-oss-bot commented Apr 10, 2024

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.47% (a58216a) to 67.89% (7a3d30f) by -0.57%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    FIRAuth.m83.68%82.53%-1.15%
    FIRAuthKeychainServices.m59.66%52.36%-7.30%
    FIRAuthStoredUserManager.m52.87%17.24%-35.63%
  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 56.97% (a58216a) to 56.91% (7a3d30f) by -0.06%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    FIRDatabaseReference.m6.41%6.41%-0.00%
    FWebSocketConnection.m41.74%37.19%-4.55%
  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from 61.52% (a58216a) to 57.96% (7a3d30f) by -3.56%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    FIRDLDefaultRetrievalProcessV2.m14.04%0.00%-14.04%
    FIRDLJavaScriptExecutor.m24.81%0.00%-24.81%
    FIRDLRetrievalProcessFactory.m100.00%0.00%-100.00%
    FIRDynamicLinks.m71.30%69.70%-1.60%
  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 40.71% (a58216a) to 40.81% (7a3d30f) by +0.11%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    DocumentID.swift86.44%86.67%+0.23%
  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.12% (a58216a) to 88.18% (7a3d30f) by +0.06%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    exception.cc23.68%84.21%+60.53%
    grpc_stream.cc99.01%98.02%-0.99%
    leveldb_key.cc99.02%98.43%-0.59%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    local_serializer.cc87.78%88.33%+0.56%
    write_stream.cc91.55%94.37%+2.82%
  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from 44.74% (a58216a) to 44.73% (7a3d30f) by -0.01%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    FIRIAMDefaultDisplayImpl.m1.78%1.78%-0.00%
    FIRInAppMessaging.m3.37%3.37%-0.00%
  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.03% (a58216a) to 60.14% (7a3d30f) by +0.11%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    FIRMessagingCheckinPreferences.m93.07%98.02%+4.95%
    FIRMessagingExtensionHelper.m77.92%78.79%+0.87%
  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from 72.98% (a58216a) to 72.29% (7a3d30f) by -0.69%.

    FilenameBase (a58216a)Merge (7a3d30f)Diff
    RCNConfigFetch.m74.13%73.52%-0.61%
    RCNConfigRealtime.m50.63%46.62%-4.01%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/58lqOmeB4P.html

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Apr 11, 2024
@paulb777
Copy link
Member Author

Clean CI here except for a frequent flake from the macos-14 swift-build-run in spm.yml:

Failing tests:
-[UseUserAccessGroupTests testUseUserAccessGroup]

@paulb777 paulb777 requested a review from ncooke3 April 12, 2024 16:05
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And thanks for opening the separate issues for the TODOs!

@paulb777 paulb777 merged commit 1cde471 into main Apr 12, 2024
549 of 550 checks passed
@paulb777 paulb777 deleted the pb-end-xcode14 branch April 12, 2024 16:55
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager May 1, 2024
….25.0" (#1056)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk)
| minor | `from: "10.24.0"` -> `from: "10.25.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.25.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.25.0):
Firebase Apple 10.25.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.24.0...10.25.0)

The Firebase Apple SDK (10.25.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.25.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[FirebaseCoreInternal] Switch to implementation-only import of GULs
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12714](https://togithub.com/firebase/firebase-ios-sdk/pull/12714)
- \[AppCheck, Database, InAppMessaging, MLModelDownloader, Performance,
Sessions] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[#&#8203;12752](https://togithub.com/firebase/firebase-ios-sdk/issues/12752),
[#&#8203;12753](https://togithub.com/firebase/firebase-ios-sdk/issues/12753),
[#&#8203;12757](https://togithub.com/firebase/firebase-ios-sdk/issues/12757),
[#&#8203;12759](https://togithub.com/firebase/firebase-ios-sdk/issues/12759),
[#&#8203;12762](https://togithub.com/firebase/firebase-ios-sdk/issues/12762),
[#&#8203;12773](https://togithub.com/firebase/firebase-ios-sdk/issues/12773)
- Use declspec in Firestore on Windows machines by
[@&#8203;a-maurice](https://togithub.com/a-maurice) in
[https://github.com/firebase/firebase-ios-sdk/pull/12758](https://togithub.com/firebase/firebase-ios-sdk/pull/12758)
- \[CI] Stop Xcode 14, start Xcode 15.3 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12746](https://togithub.com/firebase/firebase-ios-sdk/pull/12746)
- \[Performance] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12759](https://togithub.com/firebase/firebase-ios-sdk/pull/12759)
- Todos and workarounds for tests not yet ready for macos-14 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12781](https://togithub.com/firebase/firebase-ios-sdk/pull/12781)
- Another macos-14 CI workaround by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12787](https://togithub.com/firebase/firebase-ios-sdk/pull/12787)
- \[CI] Update grpc dependent jobs to macos-14 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12790](https://togithub.com/firebase/firebase-ios-sdk/pull/12790)
- \[Firestore] Remove DocumentID setter warning by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12756](https://togithub.com/firebase/firebase-ios-sdk/pull/12756)
- \[App Check] Bump dependency on AppCheckCore to 10.19.0+ by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12806](https://togithub.com/firebase/firebase-ios-sdk/pull/12806)
- Allow Blob of data with zero length. by
[@&#8203;tom-andersen](https://togithub.com/tom-andersen) in
[https://github.com/firebase/firebase-ios-sdk/pull/12694](https://togithub.com/firebase/firebase-ios-sdk/pull/12694)
- \[Infra] Switch zip building over to Xcode 15.2 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12737](https://togithub.com/firebase/firebase-ios-sdk/pull/12737)
- Make use of
SQLITE_OPEN_FILEPROTECTION_COMPLETEUNTILFIRSTUSERAUTHENTICATION
conditional. by
[@&#8203;cprince-foreflight](https://togithub.com/cprince-foreflight) in
[https://github.com/firebase/firebase-ios-sdk/pull/12548](https://togithub.com/firebase/firebase-ios-sdk/pull/12548)
- \[Release Tooling] Consistent approach to resources when building on
Xcode 15 by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12821](https://togithub.com/firebase/firebase-ios-sdk/pull/12821)
- \[Release Tooling] Cleanup unused folder references by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12825](https://togithub.com/firebase/firebase-ios-sdk/pull/12825)
- Analytics 10.25.0 by [@&#8203;pcfba](https://togithub.com/pcfba) in
[https://github.com/firebase/firebase-ios-sdk/pull/12843](https://togithub.com/firebase/firebase-ios-sdk/pull/12843)
- Update `FIRAuthInterop` to use `_Nullable_result` annotation by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12841](https://togithub.com/firebase/firebase-ios-sdk/pull/12841)
- Disable quickstart CI that doesn't work with Xcode 15 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12846](https://togithub.com/firebase/firebase-ios-sdk/pull/12846)

#### New Contributors

- [@&#8203;mrs1669](https://togithub.com/mrs1669) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12760](https://togithub.com/firebase/firebase-ios-sdk/pull/12760)
- [@&#8203;a-maurice](https://togithub.com/a-maurice) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12758](https://togithub.com/firebase/firebase-ios-sdk/pull/12758)
- [@&#8203;cprince-foreflight](https://togithub.com/cprince-foreflight)
made their first contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12548](https://togithub.com/firebase/firebase-ios-sdk/pull/12548)

**Full Changelog**:
firebase/firebase-ios-sdk@10.24.0...10.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants