Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Add App Check to integration tests #13098

Closed
wants to merge 2 commits into from
Closed

[Vertex AI] Add App Check to integration tests #13098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
589d6f1
[Vertex AI] Add App Check to integration tests
andrewheard Jun 7, 2024
ba4b370
Add FirebaseAppCheck dependency
andrewheard Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/vertexai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
runs-on: ${{ matrix.os }}
env:
TEST_RUNNER_VertexAIRunIntegrationTests: 1
TEST_RUNNER_FIRAAppCheckDebugToken: ${{ secrets.VERTEXAI_INTEGRATION_FAC_DEBUG_TOKEN }}
FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
steps:
Expand Down
3 changes: 3 additions & 0 deletions FirebaseVertexAI/Tests/Integration/IntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import FirebaseAppCheck
import FirebaseCore
import FirebaseVertexAI
import XCTest
Expand All @@ -30,6 +31,8 @@ final class IntegrationTests: XCTestCase {
environment variable in Xcode or CI jobs.
""")

AppCheck.setAppCheckProviderFactory(AppCheckDebugProviderFactory())

let plistPath = try XCTUnwrap(Bundle.module.path(
forResource: "GoogleService-Info",
ofType: "plist"
Expand Down
5 changes: 4 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,10 @@ let package = Package(
),
.testTarget(
name: "FirebaseVertexAIIntegration",
dependencies: ["FirebaseVertexAI"],
dependencies: [
"FirebaseAppCheck",
"FirebaseVertexAI",
],
path: "FirebaseVertexAI/Tests/Integration",
resources: [
.process("Resources"),
Expand Down
Loading