Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Use GITHUB_TOKEN for repo tagging #13217

Merged
merged 3 commits into from
Jul 2, 2024
Merged

[Infra] Use GITHUB_TOKEN for repo tagging #13217

merged 3 commits into from
Jul 2, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jul 2, 2024 •
edited
Loading

  • Use the gitHub-generated GITHUB_TOKEN scoped to this repo for pushing nightly tags instead of the global access token.
  • Remove oss-bot secret

latest CI: https://github.com/firebase/firebase-ios-sdk/actions/runs/9768323572 (not done, but relevant part has passed)

expecation: I need to add permissions to workflow, maybe

#no-changelog

@ncooke3 ncooke3 marked this pull request as ready for review July 2, 2024 21:51
@ncooke3 ncooke3 requested a review from paulb777 July 2, 2024 21:51
@ncooke3 ncooke3 merged commit eca84fd into main Jul 2, 2024
38 checks passed
@ncooke3 ncooke3 deleted the nc/scripting-3 branch July 2, 2024 22:23
@firebase firebase deleted a comment from ncooke3 Jul 2, 2024
@firebase firebase deleted a comment from ncooke3 Jul 2, 2024
@ncooke3 ncooke3 mentioned this pull request Jul 30, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncooke3 @paulb777