Async Function Calling #13901
Merged
Async Function Calling #13901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakovmanshin
force-pushed
the
async-function-calling
branch
from
f7a0de2
to
2b63774
Compare
|
TODO: Integration tests are failing: IntegrationTests.testCallAsFunction()
IntegrationTests.testExplicitErrorAsync()
IntegrationTests.testExplicitErrorAsync()
IntegrationTests.testExplicitErrorAsync()
IntegrationTests.testExplicitErrorAsync()
IntegrationTests.testThrowErrorAsync()
IntegrationTests.testUnknownErrorAsync()
IntegrationTests.testUnknownErrorAsync() |
yakovmanshin
force-pushed
the
async-function-calling
branch
from
ff350ee
to
1f39374
Compare
yakovmanshin
commented
Oct 25, 2024
* Introduced an async / await version of `callFunction` which takes advantage of `FunctionsContextProvider`’s async `context(options:)` * Refactored `GTMSessionFetcher` setup to minimize code duplication * Added tests
* `GTMSessionFetcher`’s async `beginFetch()` method returns either data or error, but not both (unlike the completion-handler variant) * Without the data, `processedResponseData(from:error:)` has less details and can’t categorize the error correctly * However, the same details can be retrieved from the error’s user info
yakovmanshin
force-pushed
the
async-function-calling
branch
from
1f39374
to
d77a97d
Compare
paulb777
approved these changes
Oct 29, 2024
ncooke3
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callFunctionwhich takes advantage ofFunctionsContextProvider’s asynccontext(options:)GTMSessionFetchersetup to minimize code duplication