[CoreExtension] Remove NS_SWIFT_UNAVAILABLE attribute that caused breaking change
#13942
Conversation
|
Wow!! Very fast support! |
| @@ -53,7 +53,7 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration | |||
| # Remember to also update version in `cmake/external/GoogleUtilities.cmake` | |||
| s.dependency 'GoogleUtilities/Environment', '~> 8.0' | |||
| s.dependency 'GoogleUtilities/Logger', '~> 8.0' | |||
| s.dependency 'FirebaseCoreInternal', '~> 11.0' | |||
| s.dependency 'FirebaseCoreInternal', '~> 11.4' | |||
There was a problem hiding this comment.
FirebaseCoreInternal added API in 11.4 that FirebaseCore depends on so FirebaseCore's dependency on FirebaseCoreInternal needs to be updated like this.
FirebaseCoreExtension.podspec
Outdated
| @@ -34,5 +34,5 @@ Pod::Spec.new do |s| | |||
| "#{s.module_name}_Privacy" => 'FirebaseCore/Extension/Resources/PrivacyInfo.xcprivacy' | |||
| } | |||
|
|
|||
| s.dependency 'FirebaseCore', '~> 11.0' | |||
| s.dependency 'FirebaseCore', '>= 11.4.1', '< 12.0' | |||
There was a problem hiding this comment.
Because FirebaseCoreExtension depends on FirebaseCore yet shares the same headers in its sources, they should be versioned together whenever these headers change.
There was a problem hiding this comment.
so how do i apply this now to my pod or code
There was a problem hiding this comment.
Hi @jenkinsernest, I added a comment for you over in firebase/flutterfire#13527 (comment)
FirebaseCoreExtension.podspec
Outdated
| @@ -34,5 +34,5 @@ Pod::Spec.new do |s| | |||
| "#{s.module_name}_Privacy" => 'FirebaseCore/Extension/Resources/PrivacyInfo.xcprivacy' | |||
| } | |||
|
|
|||
| s.dependency 'FirebaseCore', '~> 11.0' | |||
| s.dependency 'FirebaseCore', '>= 11.4.1', '< 12.0' | |||
There was a problem hiding this comment.
@andrewheard , going to revert this because it will make 11.4.1 incompatible with Firebase Core 11.2, which then will require a Flutter update to pick up the fixed FirebaseCoreExtension.
Fixing the issue causing the regression in firebase/flutterfire#13527 (comment) that was introduced in #13853