Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix iOS 12 spec lint failure from incomplete FirebaseCoreInternal implementation #13952

Merged
merged 14 commits into from
Oct 22, 2024
Merged

[Core] Fix iOS 12 spec lint failure from incomplete FirebaseCoreInternal implementation #13952

merged 14 commits into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. [Core] Add availability gate on implementation

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2907dbc View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3e9c506 View commit details
    Browse the repository at this point in the history

  3. bump specs

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e4af499 View commit details
    Browse the repository at this point in the history

  4. undo bump in extension pod

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    73cb34f View commit details
    Browse the repository at this point in the history

  5. Runtime approach

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7db9bdd View commit details
    Browse the repository at this point in the history

  6. Move issue down into FirebaseCoreInternal

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cde104d View commit details
    Browse the repository at this point in the history

  7. Revert "Runtime approach" 

    This reverts commit 7db9bdd.
    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    94bb5ee View commit details
    Browse the repository at this point in the history

  8. [skip ci] review

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4fbdbce View commit details
    Browse the repository at this point in the history

  9. [skip ci] review: changelog

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a2c8aae View commit details
    Browse the repository at this point in the history

  10. Bump FirebaseCoreInternal

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1a5827b View commit details
    Browse the repository at this point in the history

  11. Bump core's dep on coreinternal

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5e6b55d View commit details
    Browse the repository at this point in the history

  12. Add TODO

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    13affce View commit details
    Browse the repository at this point in the history

  13. Fix auth test build failure from global test run

    @ncooke3
    ncooke3 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4e9c6dd View commit details
    Browse the repository at this point in the history

  14. [Core] Prefer completion handler APIs in Core Internal (#13954)

    @ncooke3
    ncooke3 authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    181c7c8 View commit details
    Browse the repository at this point in the history