-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vertex AI] Add test app for integration tests #13960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
My only concern is that I don't see any tests in the log at https://github.com/firebase/firebase-ios-sdk/actions/runs/11525405469/job/32088217991
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the minimum iOS version needs to be set on the xcodebuild command?
Interestingly it only seems to produce output when I intentionally make the tests fail (e.g., this previous run). I was also able to see the calls to App Check in the Firebase Console for this CI run (they now show verified).
I'll dig into why the tests aren't listed one by one when they succeed in a follow-up PR. I'll also drop the deployment target to iOS 15 (it's unnecessarily high at 17.2 -- I forgot to change the default in the new Xcode project). |
#no-changelog