Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Disable xcodebuild parallel testing #13985

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 29, 2024

Set the -parallel-testing-enabled flag to NO in xcodebuild for the vertexai / testapp-integration tests. The integration tests likely shouldn't run in parallel and the output produced by parallel testing (the default in new Xcode projects) seems to be unsupported by xcpretty (xcpretty/xcpretty#295). This fixes the logs, which now show passing tests.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review October 29, 2024 02:03
@andrewheard andrewheard requested a review from paulb777 October 29, 2024 02:03
@paulb777
Copy link
Member

Good find. Thanks!

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set this for other integration testing targets too?

@andrewheard
Copy link
Contributor Author

Should we set this for other integration testing targets too?

@ncooke3 That's a good question. I do see at least one other Xcode project in the repo (AppQualityDevApp.xcodeproj) showing "Execute in parallel" so it could be worth considering:

Screenshot

AppQualityDevApp Scheme Screenshot

@ncooke3
Copy link
Member

ncooke3 commented Oct 29, 2024

Should we set this for other integration testing targets too?

@ncooke3 That's a good question. I do see at least one other Xcode project in the repo (AppQualityDevApp.xcodeproj) showing "Execute in parallel" so it could be worth considering:

Screenshot

Probably OK to leave for now. We now know how to update it if it becomes a problem.

@andrewheard andrewheard merged commit 7244f54 into main Oct 29, 2024
49 checks passed
@andrewheard andrewheard deleted the ah/vertex-disable-parallel-testing branch October 29, 2024 18:50
@firebase firebase locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants