Add FirebaseAuth test_spec #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paulb777
commented
Jun 1, 2019
•
paulb777
commented
- Add unit test spec for Auth.
- Add a complete Auth build and test rule.
- Testing is done via the pod gen generated workspace.
- AuthSample and its associated tests are migrated to their own isolated xcodeproj and associated Podfile.
- I've verified that CI will build and run the integration tests, but they're currently disabled in .travis.yml because of backend issues.
- Directory structure will be cleaned up in a future PR.
- Fix unit test warnings.
- Fix string in tests that failed in c99 builds.
- Eliminate sharedApplication mocks that expose Crash in NSInvocation -dealloc when using OCMPartialMock erikdoe/ocmock#346 on iPhone 4 test runs.
- The old build environment is still supported.
- It will be removed when all pods have transitioned to test_specs and pod gen.
- For now, see the instructions at https://github.com/firebase/firebase-ios-sdk/blob/master/Functions/README.md.
- pod gen FirebaseAuth.podspec --local-sources=./ --auto-open
renkelvin
approved these changes
Jun 6, 2019
| - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuth.podspec --platforms=ios | ||
| - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuth.podspec --platforms=tvos | ||
| - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuth.podspec --platforms=macos | ||
| # TODO (renkelvin) Uncomment next line when Auth backend is fixed to support the integration tests. |
| @@ -161,11 +172,29 @@ jobs: | |||
| before_install: | |||
| - ./scripts/install_prereqs.sh | |||
| script: | |||
| # TODO investigate why macos tests hang for FirebaseAuth - keychain related? | |||
There was a problem hiding this comment.
I guess so. The OS asks for password when you want to access to the keychain.
There was a problem hiding this comment.
I suspect that it's related to the password, but somehow the dynamic framework version works.
| didReceiveRemoteNotification:notification | ||
| fetchCompletionHandler:^(UIBackgroundFetchResult result) {}]; | ||
|
|
||
| [self.mockNotificationManager verify]; | ||
| } | ||
|
|
||
| - (void)testAppOpenURL_AuthPresenterCanHandleURL { | ||
| NSURL *url = [NSURL URLWithString:@"https://localhost"]; | ||
| if (@available(iOS 9.0, *)) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.