Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readme or documentation about decoding jwt #569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SySafarila
Copy link

fixing typo on Readme about JWT Decode parameter from $payload to $jwt.

before fixed:

JWT::decode($payload, $key);

after fixed:

JWT::decode($jwt, $key);

Copy link

google-cla bot commented Jun 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@SySafarila
Copy link
Author

Hello, my name is Syahrul Safarila. I just reading the Readme and find out that some documentation about decoding JWT are need variable called $payload instead of $jwt.

i hope this pull request can help other developers to understand required parameter for decoding JWT.

@SySafarila SySafarila changed the title Update README.md fix: readme or documentation about decoding jwt Jun 23, 2024
@bshaffer
Copy link
Collaborator

Hi @SySafarila ! Thanks for your contribution, this looks great!

Before we can merge it, you will need to sign our Contributor License Agreement (CLA). All contributors must be covered under a CLA for them to contribute to our open source repositories.

Please visit https://cla.developers.google.com/. Once you've signed, follow the "New Contributors" link at the bottom of that page to update this check.

Thanks again!

@SySafarila
Copy link
Author

hi @bshaffer !, I have registered on the CLA already, and its look like just need a reviewer for this pull request to get merge

fixing typo on JWT Decode parameter from $payload to $jwt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants