-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade firecracker to 1.4.1 #486
Conversation
c112c5e
to
e840cf2
Compare
63ae1a7
to
5b8c168
Compare
Waiting for #495 to merge to unblock build issue. |
Thanks! From test perspetive, change that is enough to test with firecracker 1.4.0 |
1. Pull swagger specs from firecracker 2. `go generate` to rebuild the client 3. Upgrade version in the Makefile Signed-off-by: Tony Fang <[email protected]>
5b8c168
to
73ce43b
Compare
Signed-off-by: Tony Fang <[email protected]>
Since firecracker 1.4.1 was released, upgrade to it directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Upgrade firecracker from 1.0.0 to 1.4.1
Description of changes:
Upgrade firecracker to 1.4.1
firecracker-microvm/firecracker@v1.0.0...v1.4.1
PR #495 has upgraded firecracker partially to 1.4.1(only snapshot memory backend was added, not all swagger specs were in sync with v1.4.1), this PR is a followup to make sure swagger files are in sync and client were generated.
go generate
to rebuild the clientMissing features not yet implemented at sdk side are captured in the list.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign-off-by: Tony Fang [email protected]