Ksagiyam/io do not use pickle #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/io_do_not_use_pickle
branch
2 times, most recently
from
20e4d76
to
8b99dbc
Compare
ksagiyam
force-pushed
the
ksagiyam/io_do_not_use_pickle
branch
from
8b99dbc
to
2e070b4
Compare
dham
reviewed
Mar 8, 2023
firedrake/bcs.py
Outdated
| @@ -347,11 +347,11 @@ def function_arg(self, g): | |||
| try: | |||
| g = as_ufl(g) | |||
| self._function_arg = g | |||
| except UFLException: | |||
| except BaseException: | |||
dham
reviewed
Mar 8, 2023
firedrake/checkpointing.py
Outdated
|
|
||
| def _load_ufl_element(self, path, name): | ||
| if self.has_attr(path, name + "_repr"): | ||
| return eval(self.get_attr(path, name + "_repr")) |
There was a problem hiding this comment.
locals = {}
globals = {}
eval("from ufl import *", locals, globals)
return eval(self.get_attr(path, name + "_repr"), locals, globals)
93ce8e7
to
8c07488
Compare
ksagiyam
force-pushed
the
ksagiyam/io_do_not_use_pickle
branch
2 times, most recently
from
cca43bc
to
29b1266
Compare
|
Merged as discussed. |
stephankramer
added a commit
to thetisproject/thetis
that referenced
this pull request
Aug 18, 2023
Checkpoints should now hopefully be more stable after firedrakeproject/firedrake#2787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
reprinstead of pickling.Involves a minor fix in UFL, so depends on firedrakeproject/ufl#34