Product rule for derivative of a FormSum #45
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the product rule for
FormSum
(although I know that so far we only support constant weights).In addition, we eagerly cancel terms that are zero by checking if they depend on the variable with respect to which we are differentiating.
Also this fixes Firedrake issue #3206, as we do not return a
FormSum
when the variational term is the only one that depends on the differentiation variable.