Product rule for derivative of a FormSum #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbouziani
reviewed
Nov 8, 2023
| if coefficient in component.coefficients()] | ||
| args += [(component * derivative(weight, coefficient, argument, coefficient_derivatives), 1) | ||
| for component, weight in zip(components, weights) | ||
| if hasattr(weight, "coefficients") and coefficient in weight.coefficients()] |
There was a problem hiding this comment.
Suggested change
| if hasattr(weight, "coefficients") and coefficient in weight.coefficients()] | |
| if isinstance(weight, BaseForm)] |
| # Distribute derivative over FormSum components | ||
| return FormSum(*[(derivative(component, coefficient, argument, coefficient_derivatives), 1) | ||
| for component in form.components()]) | ||
| # Distribute derivative over FormSum components and weights that depend on coefficient |
There was a problem hiding this comment.
This won't do anything if you don't also make sure the DAG visitor is aware that it needs to visit the weights during differentiation, see
ufl/ufl/algorithms/map_integrands.py
Line 39 in cf66c4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the product rule for
FormSum(although I know that so far we only support constant weights).In addition, we eagerly cancel terms that are zero by checking if they depend on the variable with respect to which we are differentiating.
Also this fixes Firedrake issue #3206, as we do not return a
FormSumwhen the variational term is the only one that depends on the differentiation variable.