Improve initial selection in the call tree - try 2 #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
changed the title
Codecov ReportBase: 88.37% // Head: 88.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4358 +/- ##
=======================================
Coverage 88.37% 88.38%
=======================================
Files 282 282
Lines 25314 25331 +17
Branches 6826 6832 +6
=======================================
+ Hits 22371 22388 +17
Misses 2731 2731
Partials 212 212
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
At my current window height, this sometimes selects a call node which is offscreen (below the visible part of the call tree) and it doesn't scroll it into view. Can you change it so that it also scrolls it into view? |
julienw
force-pushed
the
improve-initial-selection-2
branch
from
a565b73
to
94b683e
Compare
julienw
force-pushed
the
improve-initial-selection-2
branch
from
94b683e
to
f81ef65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler version of #4357. Especially it doesn't try to open interesting sieblings.
See #4357 for links to this deploy preview.
┆Issue is synchronized with this Jira Task