Use custom splitter component #4606
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing with a different splitter implementation which lets us use
max-heighton the timeline, so that we don't have to compute the timeline height based on the visible tracks.It's working great so far and lets us remove a fair amount of code, and it's another solution to the ResizeObserver warning.
I haven't implemented the panelLayoutGeneration incrementing. The next step would be to find out whether that's still needed or whether we can remove panelLayoutGeneration as well (or maybe replace it with another ResizeObserver).
┆Issue is synchronized with this Jira Task