[Deploy preview] Revert to using Math functions in _accumulateInBuffer #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 471107b.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4772 +/- ##
==========================================
- Coverage 88.33% 88.33% -0.01%
==========================================
Files 301 301
Lines 26824 26822 -2
Branches 7240 7238 -2
==========================================
- Hits 23696 23694 -2
Misses 2915 2915
Partials 213 213
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting this here just for the deploy preview, so that I can file a bug about the Math performance problem that I found.
Filed as https://bugzilla.mozilla.org/show_bug.cgi?id=1858310
Unfortunately the deploy preview for this PR is still using the production build. I'm not sure how to make it use the development build, for easier testing.Changed to use the development build┆Issue is synchronized with this Jira Task