Support a richer variety of virtualenv directories #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a python interpreter is specified to virtualenv using, eg --python=python2.7, then this script ends up not rewriting the #! lines. Instead of a suffix match, check that they end with something that exists in the bin directory, and if so update them to point to that same thing in the new path.
PyPy uses a slightly different virtualenv layout; instead of lib/python2.7 you'll see lib-python/2.7; adapt accordingly. Also its bin/python ends up being a symlink. Finally, there is a bin/__pycache__ directory which needs skipping in update_script().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2.