Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compatibility for Pydantic v2 #17

Closed
wants to merge 2 commits into from
Closed

Add Compatibility for Pydantic v2 #17

wants to merge 2 commits into from

Conversation

japerry911
Copy link

Summary

  • makes prefect-fivetran compatible with Pydantic v2 Installed.

Relevant Issue(s)

#16
#15

Checklist

@japerry911 japerry911 mentioned this pull request Jan 23, 2024
Open
fivetran-aleksandrboldyrev
fivetran-aleksandrboldyrev approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@japerry911
Copy link
Author

@fivetran-aleksandrboldyrev @fivetran-nenad-stanojev

Are these tests outdated?

@fivetran-aleksandrboldyrev
Copy link
Collaborator

@fivetran-aleksandrboldyrev @fivetran-nenad-stanojev

Are these tests outdated?

Looks like - yes

@japerry911
Copy link
Author

closing as another PR addresses this

@japerry911 japerry911 closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fivetran-aleksandrboldyrev fivetran-aleksandrboldyrev fivetran-aleksandrboldyrev approved these changes

@fivetran-nenad-stanojev fivetran-nenad-stanojev fivetran-nenad-stanojev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@japerry911 @fivetran-aleksandrboldyrev @fivetran-nenad-stanojev