Handle changed ntpath.isabs behaviour in Python 3.13 (#110) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntpath.isabs no longer considers paths that start with "/" to be absolute. This is correct behaviour on Windows but causes us problems, because our `PathConstants` use paths that start with / and expect these to always be considered absolute. To deal with this, let's add an extra slash to the `PathConstants`; paths starting `//` are considered absolute by both ntpath and posixpath. Signed-off-by: Adam Williamson <[email protected]>
|
The CI failure seems to be just because github no longer offers Python 2.x. |
roehling
added a commit
that referenced
this pull request
Sep 20, 2024
In the early days, catkin_lint was unable to do sophisticated path name analysis, which is why some checks ignored absolute paths as a workaround. As the workaround is no longer required, fix the check for valid INCLUDE_DIRS. This commit also supersedes the proposed solutions in #111 and #112. Fixes #110
|
Thank you for your PR, after some review I decided to fix the underlying issue, i.e., the somewhat hacky usage of path.isabs(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ntpath.isabs no longer considers paths that start with "/" to be absolute. This is correct behaviour on Windows but causes us problems, because our
PathConstantsuse paths that start with / and expect these to always be considered absolute. To deal with this, let's add an extra slash to thePathConstants; paths starting//are considered absolute by both ntpath and posixpath.This is an alternative to #111 , it probably doesn't make sense to do both.