feat: Add onDispose
to game.dart
called from game_widget.dart
#2659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds, imo, the missing piece in the event lifecycle based on all the other lifecycle work I have been doing.
Currently, when dispose is called in
game_widget.dart
, it callsdisposeCurrentGame
which has the call foronRemove
, at issue though is,disposeCurrentGame
is also called bydidUpdateWidget
if theoldWidget.game != widget.game
. It may not be needed, but I feel like becauseFlameGame
is inherently a stateless set of widgets (children of the LeafRenderObjectWidget), the hook foronRemove
is muddled with what is NOT actually a dispose event. So my thought is, introduce theonDispose
method to game which gets called by makingdisposeCurrentGame({isDispose = false})
then in the actual overriddendispose
method, pass that as true, so we can then callcurrentGame.onDispose()
after the call tocurrentGame.onRemove()
.Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues