Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Melos root path not needed for running doc setup script #3340

Merged
merged 3 commits into from
Oct 13, 2024
Merged

ci: Melos root path not needed for running doc setup script #3340

merged 3 commits into from
Oct 13, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Oct 13, 2024

Description

It needs to use the full root path to find the script.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon changed the title ci: Use full melos root path for running doc setup script ci: Melos root path not needed for running doc setup script Oct 13, 2024
luanpotter
luanpotter approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon enabled auto-merge (squash) October 13, 2024 15:32
@spydon spydon merged commit 0041604 into main Oct 13, 2024
8 checks passed
@spydon spydon deleted the ci/full-root-path branch October 13, 2024 15:32
luanpotter pushed a commit that referenced this pull request Oct 15, 2024
@spydon @luanpotter
ci: Melos root path not needed for running doc setup script (#3340)
a1a62ba 
It needs to use the full root path to find the script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @luanpotter