Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update component lifecycle diagram to be correct #3357

Merged
merged 3 commits into from
Oct 28, 2024
Merged

docs: Update component lifecycle diagram to be correct #3357

merged 3 commits into from
Oct 28, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Oct 28, 2024

Description

The onMount and onRemove nodes were the wrong color in the diagram.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

erickzanardo
erickzanardo reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that changed were the colours, is that correct???

erickzanardo
erickzanardo approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is!

@spydon spydon enabled auto-merge (squash) October 28, 2024 16:46
@spydon spydon merged commit a8bcca0 into main Oct 28, 2024
8 checks passed
@spydon spydon deleted the docs/update-component-lifecycle-diagram branch October 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @erickzanardo