Apply suggestions from code review

Co-authored-by: Yuriy Losev <[email protected]>
flant · Oct 22, 2024 · 38cd01e · 38cd01e
1 parent c9e488b
commit 38cd01e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/pkg/helm/post_renderer/post_renderer.go b/pkg/helm/post_renderer/post_renderer.go
@@ -19,15 +19,15 @@ func (p *PostRenderer) Run(renderedManifests *bytes.Buffer) (modifiedManifests *
 	if err != nil {
 		return nil, fmt.Errorf("parse rendered manifests failed: %v", err)
 	}
-	for _, v := range nodes {
-		labels := v.GetLabels()
+	for _, node := range nodes {
+		labels := node.GetLabels()
 		if labels == nil {
-			labels = make(map[string]string)
+			labels = make(map[string]string, len(p.ExtraLabels))
 		}
 		for k, v := range p.ExtraLabels {
 			labels[k] = v
 		}
-		v.SetLabels(labels)
+		node.SetLabels(labels)
 	}
 
 	str, err := kio.StringAll(nodes)

diff --git a/pkg/helm_resources_manager/test/mock/mock.go b/pkg/helm_resources_manager/test/mock/mock.go
@@ -17,10 +17,6 @@ func (h *MockHelmResourcesManager) WithContext(_ context.Context) {}
 
 func (h *MockHelmResourcesManager) WithKubeClient(_ *klient.Client) {}
 
-func (h *MockHelmResourcesManager) WithCache(_ context.Context) error {
-	return nil
-}
-
 func (h *MockHelmResourcesManager) WithDefaultNamespace(_ string) {}
 
 func (h *MockHelmResourcesManager) Stop() {}