Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes mnd in addition to gomnd #31

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Excludes mnd in addition to gomnd #31

merged 2 commits into from
Aug 30, 2024

Conversation

Ruteri
Copy link
Contributor

@Ruteri Ruteri commented Aug 30, 2024

πŸ“ Summary

Excludes mnd as only excluding gomnd does not work in more recent versions.

β›± Motivation and Context

mnd is not cool most of the time

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test
  • go mod tidy

@metachris
Copy link
Collaborator

I think the golangci-lint version used in CI is not having this linter:

level=error msg="Running error: unknown linters: 'mnd', run 'golangci-lint help linters' to see the list of supported linters"

you could update the linter version here: https://github.com/flashbots/go-template/blob/main/.github/workflows/checks.yml#L46

@metachris metachris merged commit d3d41f9 into main Aug 30, 2024
2 checks passed
@metachris metachris deleted the exclude-mnd branch August 30, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants