Fixed bug causing "Unknown speaker!" in ami recipe #977
Conversation
Judging by assertion (line 115) and speaker access (line 117) statements, I think on line 111 the intention was to create a dictionary from the list of speakers {speaker.id: speaker for speaker in speakers}, but instead a set of tuples {(speaker.id, speaker) for speaker in speakers} was created, causing assert speaker in speakers to fail. I fixed it accordingly.
|
Hi @alkazap! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Original Issue: #976
closes #[976]
Summary
python prepare.pyfails withAssertionError: Unknown speaker! FEE005Test Plan (required)
Assertion error comes from
utils.pyline 117assert speaker in speakers, f"Unknown speaker! {speaker}"Judging by the assertion and line 119
speaker = speakers[speaker], the script expectsspeakersto be a dictionary, however, as we can see on line 111speakers = {(speaker.id, speaker) for speaker in speakers},speakersis a set of tuples.Line 111 should be
speakers = { speaker.id : speaker for speaker in speakers }, then the script works as intended.