Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add ore command to create azure gallery #523

Draft
wants to merge 19 commits into
base: flatcar-master
Choose a base branch
from

Conversation

jepio
Copy link
Member

@jepio jepio commented Apr 12, 2024

No description provided.

We want to indicated support for trusted launch (TPM + secure boot) for
testing. Trusted launch is only availabe for Gen2 VMs so we need some
conditional template magic to continue working for Gen1 VMs. We also
need to indicate image support for NVMe for testing NVMe only instances.
For completeness we also mark support for accelerated networking.

Signed-off-by: Jeremi Piotrowski <[email protected]>
Since all ore commands call WrapPreRun, they overwrite the default
implementation that calls StartLogging(). To get plog to work
StartLogging() must be called manually.

Signed-off-by: Jeremi Piotrowski <[email protected]>
So that commands can set fields like 'Board' later on.

Signed-off-by: Jeremi Piotrowski <[email protected]>
This ore command creates a gallery image for use in multiple VM
creations, and could be used to speed up multiple kola invocations.  The
command takes care of uploading the vhd to blob storage and creates
resource group and storage account as well.

Signed-off-by: Jeremi Piotrowski <[email protected]>
Now that our gallery images are created with trusted launch support, we
can enable trusted launch and TPM on the instance. At some point we'll
be able to pass custom secure boot keys too.

Signed-off-by: Jeremi Piotrowski <[email protected]>
We currently create a storage account for every test cluster. Storage account
creation takes 20-30 seconds. This storage account is only used for VM console
logs. We can easily reuse a single storage account for all vm console logs,
thereby speeding up the whole test execution.

Introduce a field called storageAccountRG in struct cluster, so that we can
keep track of the correct RG when fetching VM logs.

Signed-off-by: Jeremi Piotrowski <[email protected]>
So that the deferred flight.Destroy() is called. The only caller terminates the
application on failure anyway.
This makes it harder to track down legit failures.
This does not require that the user have RBAC permissions to a storage account
to fetch, because it uses SAS keys behind the scenes. The previous approach
used a kola created storage account has Shared Key Access disabled for security
reasons.

Signed-off-by: Jeremi Piotrowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant