download_sysext: integrate signature verification #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Sep 27, 2023
dongsupark
force-pushed
the
dongsu/payload-file-integration
branch
from
1f3abd9
to
510652a
Compare
dongsupark
force-pushed
the
dongsu/payload-file-integration
branch
from
510652a
to
bcb2fe8
Compare
wrl
requested changes
Oct 10, 2023
|
|
||
| println!("Parsed signature data from file {:?}", from_path); | ||
|
|
||
| self.status = PackageStatus::Verified; |
There was a problem hiding this comment.
do we need a call to verify_sig_pubkey() first?
There was a problem hiding this comment.
No, parse_signature_data() is already calling verify_sig_pubkey().
https://github.com/flatcar/ue-rs/pull/12/files#diff-4bdabfe18b36b123ce8b3873dae3f39543fc6de6a80b796efddc060d34ef1c60R103
dongsupark
force-pushed
the
dongsu/payload-file-integration
branch
2 times, most recently
from
39112d0
to
a9b3019
Compare
dongsupark
force-pushed
the
dongsu/payload-file-integration
branch
from
a9b3019
to
2898cee
Compare
Move the delta update part from test/crau_verify.rs to update-format-crau. Move verify_sig into update-format-crau, so it can be imported by delta_update. Integrate signature verification in download_sysext.
Use argh for parsing cmdline parameters, instead of manually getting them.
Add example files of OMAHA request/response xml files.
dongsupark
force-pushed
the
dongsu/payload-file-integration
branch
from
2898cee
to
59dcd92
Compare
|
Improved minor things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the delta update part from
test/crau_verify.rstoupdate-format-crau.Move
verify_sigintoupdate-format-crau, so it can be imported by delta_update.Integrate signature verification in
download_sysext.