Change return types to Result in signature verification #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Nov 23, 2023
pothos
reviewed
Nov 23, 2023
dongsupark
force-pushed
the
dongsu/sigverify-return-types
branch
2 times, most recently
from
3c89abf to
97d19dc
Compare
pothos
reviewed
Nov 24, 2023
pothos
reviewed
Nov 24, 2023
pothos
reviewed
Nov 24, 2023
To deal with signature verification errors in a detailed way, let's change return type of parse_signature_data functions back to Result. Make it iterate over all signature slots to find the first valid signature. If nothing is found, return error.
dongsupark
force-pushed
the
dongsu/sigverify-return-types
branch
from
97d19dc to
4e4740c
Compare
pothos
approved these changes
Nov 24, 2023
2 tasks
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 7, 2023
Update ue-rs to 0.1.0-r4, 2023-12-05. Pulls in flatcar/ue-rs#26, flatcar/ue-rs#29, flatcar/ue-rs#30, flatcar/ue-rs#36, flatcar/ue-rs#37, flatcar/ue-rs#39, flatcar/ue-rs#40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deal with signature verification errors in a detailed way, let's change return type of
parse_signature_datafunctions back toResult.Iterate over signature slots to find a valid signature. If not found, return Error.
See also #28