change unwrap to ok_or or unwrap_or #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
changed the title
pothos
reviewed
Nov 30, 2023
dongsupark
force-pushed
the
dongsu/unwrap-no-panic
branch
from
cf40389 to
ac37636
Compare
pothos
reviewed
Nov 30, 2023
Replace a plain `unwrap()` with `ok_or` or `unwrap_or` to prevent from binaries or libs from panicking at runtime.
dongsupark
changed the title
dongsupark
force-pushed
the
dongsu/unwrap-no-panic
branch
from
ac37636 to
3f91354
Compare
pothos
approved these changes
Nov 30, 2023
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 7, 2023
Update ue-rs to 0.1.0-r4, 2023-12-05. Pulls in flatcar/ue-rs#26, flatcar/ue-rs#29, flatcar/ue-rs#30, flatcar/ue-rs#36, flatcar/ue-rs#37, flatcar/ue-rs#39, flatcar/ue-rs#40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace a plain
unwrap()withok_ororunwrap_or, to prevent from binaries or libs from panicking at runtime.Fixes #34