Cargo.toml: remove unnecessary crates bzip2, protobuf #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecssary crates, bzip2 and protobuf. Detected by cargo-machete.
For some reason cargo-machete shows false positive of uuid, which is actually needed for building ue-rs. Exlude uuid from machete.
tormath1
reviewed
Aug 1, 2024
| env_logger = "0.10" | ||
| globset = "0.4" | ||
| log = "0.4" | ||
| protobuf = "3.2.0" |
There was a problem hiding this comment.
What about this?
is this handled by another dependency?There was a problem hiding this comment.
Ah yes, it has its own Cargo.toml.
ue-rs/update-format-crau/Cargo.toml
Line 12 in c46ae8f
tormath1
approved these changes
Aug 1, 2024
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 1, 2024
Update coreos-base/ue-rs to commit 21d64e53c559b318170081a9a49ed9198d1603f5, as of 2024-08-01. Pulls in flatcar/ue-rs#55 flatcar/ue-rs#56.
1 task
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 2, 2024
Update coreos-base/ue-rs to commit 21d64e53c559b318170081a9a49ed9198d1603f5, as of 2024-08-01. Pulls in flatcar/ue-rs#55 flatcar/ue-rs#56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecssary crates,
bzip2andprotobuf. Detected bycargo-machete.For some reason cargo-machete shows false positive of uuid, which is actually needed for building ue-rs. Exlude uuid from machete.