decode_payload: Skip over signature entries that cause errors #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either the printf escaping gives wrong binary data or the random dummy key signature is really broken for the oem-ami.gz 3745.1.0 amd64 payload. The error reported is: RSA operation error 007E9295D47F0000:error:02000084:rsa routines:rsa_ossl_public_decrypt:data too large for modulus:crypto/rsa/rsa_ossl.c:661: 007E9295D47F0000:error:1C880004:Provider routines:rsa_verify_recover:RSA lib:providers/implementations/signature/rsa_sig.c:748:
|
Didn't find a quoting issue unless it's in |
pothos
changed the title
|
I think this really happens because we try to check the dummy signature with the production update key and this expected to fail but probably there are different failure modes depending on the internal values. |
krnowak
approved these changes
Nov 1, 2023
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Nov 2, 2023
This pulls in flatcar/update_engine#31 to correctly skip over signature entries that cause errors which can be the case for the dummy signatures.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Nov 2, 2023
This pulls in flatcar/update_engine#31 to correctly skip over signature entries that cause errors which can be the case for the dummy signatures.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Nov 2, 2023
This pulls in flatcar/update_engine#31 to correctly skip over signature entries that cause errors which can be the case for the dummy signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either the printf escaping gives wrong binary data or the random dummy key signature is really broken for the oem-ami.gz 3745.1.0 amd64 payload.
The error reported is:
RSA operation error
007E9295D47F0000:error:02000084:rsa routines:rsa_ossl_public_decrypt:data too large for modulus:crypto/rsa/rsa_ossl.c:661: 007E9295D47F0000:error:1C880004:Provider routines:rsa_verify_recover:RSA lib:providers/implementations/signature/rsa_sig.c:748:
How to use
Backport to Beta
Testing done