[WIP] Add org.brlcad.BRL_CAD #4363

kevinsmia1939 · 2023-07-26T01:31:42Z

Please confirm your submission meets all the criteria

I have read the App Requirements and App Maintenance pages.
My pull request follows the instructions at App Submission.
I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:Package BRL-CAD as Flatpak for Linux distros BRL-CAD/brlcad#88
I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.) Metainfo submitted Add metainfo for BRL-CAD BRL-CAD/brlcad#87

kevinsmia1939 · 2023-07-26T01:32:00Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2023-07-26T01:32:01Z

Queued test build for org.brlcad.BRL_CAD.

org.brlcad.BRL_CAD.yaml

hfiguiere · 2023-07-26T01:39:09Z

org.brlcad.BRL_CAD.metainfo.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop">
+    <id>org.brlcad.BRL_CAD</id>
+    <launchable type="desktop-id">org.brlcad.BRL_CAD.mged.desktop</launchable>


this should match the app-id.

BRL-CAD is a collection of smaller software, Mged, archer, rtwizard. With mged is where things usually start.
So I'm not sure what to do here. Because org.brlcad.BRL_CAD.desktop itself does not exist. Only org.brlcad.BRL_CAD.{mged,archer,rtwizard,db}.desktop exist.

but you chose one command, didn't you?

yeah, i guess i will go with mged then

hfiguiere · 2023-07-26T01:39:59Z

org.brlcad.BRL_CAD.yaml

+  - name: BRL-CAD-metainfo-desktopfile
+    buildsystem: simple
+    build-commands:
+      - install -Dm644 mged.desktop ${FLATPAK_DEST}/share/applications/${FLATPAK_ID}.mged.desktop


this should be just ${FLATPAK_ID}.desktop. same for the icon. (based on what command is)

ok, I will use mged.desktop as ${FLATPAK_ID}.desktop

hfiguiere · 2023-07-26T01:51:17Z

org.brlcad.BRL_CAD.yaml

+
+modules:
+  - name: BRL-CAD
+    buildsystem: cmake


can it build with cmake-ninja ?

org.brlcad.BRL_CAD.yaml

flathubbot · 2023-07-26T02:53:37Z

Started test build 55159

flathubbot · 2023-07-26T03:54:25Z

Build 55159 failed

hfiguiere · 2023-07-26T12:59:00Z

org.brlcad.BRL_CAD.yaml

+      cflags: -Wno-error
+      cxxflags: -Wno-error


Suggested change

cflags: -Wno-error

cxxflags: -Wno-error

cflags: -Wno-error=stringop-overflow -Wno-error=format-truncation -Wno-error=inline

-Wno-error=format-overflow -Wno-error=dangling-pointer -Wno-error=array-bounds -Wno-error=nonnull -Wno-error=maybe-uninitialized

cxxflags: -Wno-error=stringop-overflow -Wno-error=format-truncation -Wno-error=inline

-Wno-error=format-overflow -Wno-error=dangling-pointer -Wno-error=array-bounds -Wno-error=nonnull -Wno-error=maybe-uninitialized

my bad this actually doesn't work.

upstream should fix it though.

hfiguiere · 2023-07-26T13:00:15Z

org.brlcad.BRL_CAD.yaml

+          type: git
+          tag-pattern: ^rel-([\d-]+)$
+
+    # .desktop files is removed from /misc/debian after install, so manually install them.


no they are not.

$ find . -name \*.desktop ./misc/debian/archer.desktop ./misc/debian/brlcad-db.desktop ./misc/debian/brlcad-doc-mged.desktop ./misc/debian/brlcad-doc.desktop ./misc/debian/mged.desktop ./misc/debian/rtwizard.desktop

Yeah, I was looking at the build dir not the top source dir. I change it now.

hfiguiere

Icon and images from upstream should be used instead.

org.brlcad.BRL_CAD.yaml

kevinsmia1939 · 2023-07-26T14:17:46Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2023-07-26T14:17:50Z

Queued test build for org.brlcad.BRL_CAD.

flathubbot · 2023-07-26T14:18:02Z

Started test build 55244

flathubbot · 2023-07-26T14:32:53Z

Build 55244 failed

kevinsmia1939 · 2023-07-26T14:42:50Z

oof, the website ssl cert expired

kevinsmia1939 · 2023-07-26T15:05:50Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2023-07-26T15:05:57Z

Queued test build for org.brlcad.BRL_CAD.

org.brlcad.BRL_CAD.yaml

flathubbot · 2023-07-27T15:22:12Z

Build 55437 failed

kevinsmia1939 · 2023-07-27T21:55:25Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2023-07-27T21:55:27Z

Queued test build for org.brlcad.BRL_CAD.

flathubbot · 2023-07-27T21:55:40Z

Started test build 55499

flathubbot · 2023-07-27T22:20:09Z

Build 55499 failed

kevinsmia1939 · 2023-08-03T18:28:05Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2023-08-03T18:28:07Z

Queued test build for org.brlcad.BRL_CAD.

flathubbot · 2023-08-03T18:28:19Z

Started test build 56742

flathubbot · 2023-08-03T18:48:05Z

Build 56742 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/39374/org.brlcad.BRL_CAD.flatpakref

kevinsmia1939 · 2023-08-08T19:37:08Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2023-08-08T19:37:09Z

Queued test build for org.brlcad.BRL_CAD.

flathubbot · 2023-08-08T19:43:19Z

Started test build 57679

flathubbot · 2023-08-08T20:02:39Z

Build 57679 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/40303/org.brlcad.BRL_CAD.flatpakref

kevinsmia1939 · 2023-08-22T22:32:32Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2023-08-22T22:32:34Z

Queued test build for org.brlcad.BRL_CAD.

flathubbot · 2023-08-22T22:32:46Z

Started test build 60342

flathubbot · 2023-08-22T22:50:20Z

Build 60342 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42975/org.brlcad.BRL_CAD.flatpakref

hfiguiere · 2024-03-19T03:18:09Z

org.brlcad.BRL_CAD.yaml

@@ -0,0 +1,67 @@
+app-id: org.brlcad.BRL_CAD
+runtime: org.kde.Sdk
+runtime-version: 6.5


should update to 6.6

hfiguiere · 2024-03-19T03:18:44Z

anything else to mark this as not [WIP]

kevinsmia1939 · 2024-04-04T14:36:35Z

bot, build org.brlcad.BRL_CAD

flathubbot · 2024-04-04T14:36:38Z

Queued test build for org.brlcad.BRL_CAD.

flathubbot · 2024-04-04T16:33:57Z

Started test build 112243

flathubbot · 2024-04-04T16:52:23Z

Build 112243 failed

kevin added 3 commits July 21, 2023 15:24

add brl

d99adae

add desktop file

851a12c

fix version

8960116

kevinsmia1939 mentioned this pull request Jul 26, 2023

Package BRL-CAD as Flatpak for Linux distros BRL-CAD/brlcad#88

Open

hfiguiere reviewed Jul 26, 2023

View reviewed changes

org.brlcad.BRL_CAD.yaml Outdated Show resolved Hide resolved

hfiguiere reviewed Jul 26, 2023

View reviewed changes

org.brlcad.BRL_CAD.yaml Outdated

modules:

- name: BRL-CAD

buildsystem: cmake

Copy link

Contributor

hfiguiere Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it build with cmake-ninja ?

hfiguiere reviewed Jul 26, 2023

View reviewed changes

org.brlcad.BRL_CAD.yaml Show resolved Hide resolved

update from reccommendation

9249118

hfiguiere reviewed Jul 26, 2023

View reviewed changes

hfiguiere requested changes Jul 26, 2023

View reviewed changes

hfiguiere reviewed Jul 26, 2023

View reviewed changes

org.brlcad.BRL_CAD.yaml Show resolved Hide resolved

kevin added 4 commits July 26, 2023 15:36

update upstream icon and desktop

2c31283

add doc desktop and icon

b9cc3bc

update

553cb3a

add include

ab92b4b

remove doc

de2a722

hfiguiere reviewed Jul 27, 2023

View reviewed changes

org.brlcad.BRL_CAD.yaml Outdated Show resolved Hide resolved

fix openvdb

cd38370

kevin added 2 commits July 28, 2023 16:17

disable openvdb

23e48d1

remove modules for openvdb

a93f99c

kevin added 2 commits August 8, 2023 21:33

test vdb

e99c3c9

test vdb

44bfc4a

hfiguiere reviewed Mar 19, 2024

View reviewed changes

updat esdk

73ee403

-      cflags: -Wno-error
-      cxxflags: -Wno-error
+      cflags: -Wno-error=stringop-overflow -Wno-error=format-truncation -Wno-error=inline
+        -Wno-error=format-overflow -Wno-error=dangling-pointer -Wno-error=array-bounds -Wno-error=nonnull -Wno-error=maybe-uninitialized
+      cxxflags: -Wno-error=stringop-overflow -Wno-error=format-truncation -Wno-error=inline
+        -Wno-error=format-overflow -Wno-error=dangling-pointer -Wno-error=array-bounds -Wno-error=nonnull -Wno-error=maybe-uninitialized

[WIP] Add org.brlcad.BRL_CAD #4363

Are you sure you want to change the base?

[WIP] Add org.brlcad.BRL_CAD #4363

Conversation

kevinsmia1939 commented Jul 26, 2023

Please confirm your submission meets all the criteria

kevinsmia1939 commented Jul 26, 2023

flathubbot commented Jul 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flathubbot commented Jul 26, 2023

flathubbot commented Jul 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hfiguiere left a comment

Choose a reason for hiding this comment

kevinsmia1939 commented Jul 26, 2023

flathubbot commented Jul 26, 2023

flathubbot commented Jul 26, 2023

flathubbot commented Jul 26, 2023

kevinsmia1939 commented Jul 26, 2023

kevinsmia1939 commented Jul 26, 2023

flathubbot commented Jul 26, 2023

flathubbot commented Jul 27, 2023

kevinsmia1939 commented Jul 27, 2023

flathubbot commented Jul 27, 2023

flathubbot commented Jul 27, 2023

flathubbot commented Jul 27, 2023

kevinsmia1939 commented Aug 3, 2023

flathubbot commented Aug 3, 2023

flathubbot commented Aug 3, 2023

flathubbot commented Aug 3, 2023

kevinsmia1939 commented Aug 8, 2023

flathubbot commented Aug 8, 2023

flathubbot commented Aug 8, 2023

flathubbot commented Aug 8, 2023

kevinsmia1939 commented Aug 22, 2023

flathubbot commented Aug 22, 2023

flathubbot commented Aug 22, 2023

flathubbot commented Aug 22, 2023

Choose a reason for hiding this comment

hfiguiere commented Mar 19, 2024

kevinsmia1939 commented Apr 4, 2024

flathubbot commented Apr 4, 2024

flathubbot commented Apr 4, 2024

flathubbot commented Apr 4, 2024