-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cuda array interface (clone) #333
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janden
force-pushed
the
cuda_array_interface
branch
3 times, most recently
from
August 22, 2023 21:25
ce4019b
to
8b7828a
Compare
Leave this in a separate module for reuse in other places.
Needed for cupy.
Looks like `torch.asarray` was introduced in v1.11, so for backwards compatibility, we use `as_tensor` instead.
Should be using `_data`, not `data` since the former has been transformed to the appropriate dtype, stride, and shape.
janden
force-pushed
the
cuda_array_interface
branch
from
August 23, 2023 13:01
8b7828a
to
a3bd8f3
Compare
Allows us to specify which frameworks to test. This allows us to avoid some crashes when different frameworks don't interact well (e.g., Numba will fail if it's not given the primary context).
janden
force-pushed
the
cuda_array_interface
branch
from
August 24, 2023 09:25
c7281b7
to
593abf0
Compare
Can't call `x.size`, need to use compatibility layer.
Avoids having to call `util.transfer_funcs` all the time and simplifies when we only want `to_gpu`.
Only for show right now, since we only test the `pycuda` framework pending updated interface.
Shows that these are *pycuda* examples, not for the other frameworks (to be added later).
Since we can run on any of the given frameworks, we no longer depend on the `pycuda` package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of #326 to get Jenkins runs.