Follow-up to the big reorg PR #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rearrange functions to avoid forward declarations * simplify simple interfaces code * templatize spreadinterp * templatize utils.cpp * adjust makefile * fix inconsistent prototype * another attempt * another attempt * another attempt * more templatizing * more templatizing * fixes * more templatizing * no more precision-dependent sources in library * update makefile * fix typo * get rid od utils_precindep * start migrating to std::vector * NULL -> nullptr, more vectors * more OOP and some warning fixes * remove finufft.cpp; remove blanket use of namspace std * add explanation for explicit template instantiations * shorten simpleinterfaces * pass options by reference * address review comments * revert BIGINT->UBIGINT change, seems to have bigger ramifications
|
I think I managed to confuse Github. Hopefully I can fix this by closing and reopening this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the cleanup work after the big change that removed double compilation. I try to adjust comments, improve names and address still open comments from #567.
It does not make much sense to look at the diffs before #567 is merged; but once that has happened, reviewing this should become fairly straightforward.