feat: add canonical link setup #266
Merged
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heldrida
reviewed
Oct 15, 2024
sharad-s
previously approved these changes
Oct 15, 2024
heldrida
reviewed
Oct 16, 2024
heldrida
reviewed
Oct 16, 2024
Co-authored-by: Helder Oliveira <[email protected]>
heldrida
reviewed
Oct 16, 2024
heldrida
requested changes
Oct 16, 2024
Thank you 🫡 |
heldrida
requested changes
Oct 16, 2024
heldrida
approved these changes
Oct 16, 2024
Sure thing!! 🙌 |
bcamarneiro
pushed a commit
that referenced
this pull request
Oct 16, 2024
## Why? This pull request automates the addition of the canonical meta tag to every page within the website using the `<link/>` tag. ## How? - For the docs pages, make sure the slugs passed down to the layout code to ensure appropriation of the URLs. - Used the custom function ` generateCanonicalUrl(baseUrl: string, slug?: string)` to handle canonical URLs for the base layouts ## Tickets? - [Self-referencing Canonical tags](https://linear.app/fleekxyz/issue/MKTG-234/self-referencing-canonical-tags) ## Contribution checklist? - [x] The commit messages are detailed - [x] The `build` command runs locally - [x] Assets or static content are linked and stored in the project - [x] Document filename is named after the slug - [x] You've reviewed spelling using a grammar checker - [x] For documentation, guides or references, you've tested the commands and steps - [x] You've done enough research before writing ## Security checklist? - [x] Sensitive data has been identified and is being protected properly - [x] Injection has been prevented (parameterized queries, no eval or system calls) - [x] The Components are escaping output (to prevent XSS) --------- Co-authored-by: Helder Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This pull request automates the addition of the canonical meta tag to every page within the website using the
<link/>tag.How?
generateCanonicalUrl(baseUrl: string, slug?: string)to handle canonical URLs for the base layoutsTickets?
Contribution checklist?
buildcommand runs locallySecurity checklist?