Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shanoir-issue#2132: add modality radiobutton in import from pacs #2153

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

pierrehenri-dauvergne
Copy link
Collaborator

Fix #2132

In 'import from pacs' page, add modality radio buttons:

image

Backend is ongoing in PR #2063

@jcomedouteau
Copy link
Collaborator

Waiting for open session in view

@michaelkain
Copy link
Contributor

Dear @pierrehenri-dauvergne, as the backend is now there, it would be great to test if it works please, and finish the integration of this PR please. With kind regards, Michael

@pierrehenri-dauvergne pierrehenri-dauvergne marked this pull request as ready for review September 4, 2024 13:18
@pierrehenri-dauvergne pierrehenri-dauvergne added REVIEWABLE Has to be reviewed and removed REVIEWABLE Has to be reviewed labels Sep 5, 2024
@pierrehenri-dauvergne
Copy link
Collaborator Author

Query pacs with subject = test_2132 and modality = MR:

image

Query pacs with subject = test_2132 and modality = CT:
image

It won't show studies with modality that does not match the selected modality

@pierrehenri-dauvergne pierrehenri-dauvergne added the REVIEWABLE Has to be reviewed label Sep 5, 2024
Copy link
Collaborator

@julien-louis julien-louis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I you select a modality that doesn't match the search result, it ends up as a this. This series should not be founded if the modality is not compatible.

image
image

Copy link
Collaborator

@julien-louis julien-louis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pierrehenri-dauvergne , I'm sorry but I find it not consistent enough to have 2 possible differents behaviours when a pacs search fails. When a patient is found by it's name(or any other field) but the modality doesn't check, it should stay on the same page and display a warning the same way as the other cases.
image

Screenshot from 2024-11-12 10-32-43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend REVIEWABLE Has to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGUI: import from pacs: add modality
4 participants