-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shanoir-issue#2132: add modality radiobutton in import from pacs #2153
base: develop
Are you sure you want to change the base?
shanoir-issue#2132: add modality radiobutton in import from pacs #2153
Conversation
Waiting for open session in view |
Dear @pierrehenri-dauvergne, as the backend is now there, it would be great to test if it works please, and finish the integration of this PR please. With kind regards, Michael |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pierrehenri-dauvergne , I'm sorry but I find it not consistent enough to have 2 possible differents behaviours when a pacs search fails. When a patient is found by it's name(or any other field) but the modality doesn't check, it should stay on the same page and display a warning the same way as the other cases.
Fix #2132
In 'import from pacs' page, add modality radio buttons:
Backend is ongoing in PR #2063