-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Shanoir issue#2141 log unification elk #2271
Merged
jcomedouteau
merged 24 commits into
fli-iam:develop
from
jcomedouteau:shanoir-issue#2141-log-unification-ELK
Oct 25, 2024
Merged
[Do not merge] Shanoir issue#2141 log unification elk #2271
jcomedouteau
merged 24 commits into
fli-iam:develop
from
jcomedouteau:shanoir-issue#2141-log-unification-ELK
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add user id to logs (test 1)
Unify log pattern over the app
Correct test (% in application.yml)
…nt', in breadcrumbs as well
Bumps [shanoir-downloader](https://github.com/Inria-Empenn/shanoir_downloader) from `f1a3254` to `2e4097d`. - [Commits](Inria-Empenn/shanoir_downloader@f1a3254...2e4097d) --- updated-dependencies: - dependency-name: shanoir-downloader dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
- Critical security error correction ?
Hi @pierrehenri-dauvergne, it would be great, if you could review this pr please? |
pierrehenri-dauvergne
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Overall, all logs in application should look the same.