shanoir-issue#2307: solr search detects keywords and switch to expertMode #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-louis
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Also I think that this features and the toggle switch doesn't work well together. Maybe we should remove the toggle switch. But also I think the solr syntax detection system is too weak. I think there may be requests that doesn't include any field name.
I have found a code for checking the solr syntax that I adapted to Shanoir, see my branch https://github.com/julien-louis/shanoir-ng/blob/solr-syntax-check/shanoir-ng-front/src/app/solr/text-search/solrValidator.ts
Let's discuss this with @michaelkain
shanoir-ng-front/src/app/solr/text-search/solr.text-search-mode.component.ts
Outdated
Show resolved
Hide resolved
|
@pierrehenri-dauvergne So for now let's keep the button and automatically switch to expert mode but not go back automatically to normal mode. |
…when not detecting keywords
…auvergne/shanoir-ng into shanoir-issue#2307
julien-louis
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Open solr
In the search field at the top, write one of the keywords of expertMode: centerName datasetCreationDate studyName subjectName subjectType acquisitionEquipmentName datasetId datasetName datasetNature datasetType processed examinationComment examinationDate importDate tags magneticFieldStrength pixelBandwidth sliceThickness studyId
As soon as you write any of those keyword, the research automatically switch to expertMode:
This PR also changes the syntax error message to display something more accurate:
