SHANOIRUploader - Allowing Patient ID only C-FIND request #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LaurentPV will make some more tests and come back to me |
|
Tested and Ok for me, both on patient and study root query levels. |
michaelkain
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem of issue #2435 was the condition of length over the last name.
We implemented the wildcard "" by default if only a last name was provided but then we sent an error if the last name was less than 3 characters long if it contained the wildcard "".
Without any null or empty condition, the error was always poping up if the Name field wasn't filled.
The request using only one of the other fields was then in error with always the same name length condition error pop up.
In cas of a short last name ("Li" for example), the user couldn't manage to search for the patient.
I also simplified the user interface by replacing the "Help" button with a tooltip over Patient's name textField.