shanoir-issue#2446: add list of studies of subject on subjectDelete #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, it works from subject list, but not from subject details: |
michaelkain
reviewed
Oct 21, 2024
michaelkain
reviewed
Oct 21, 2024
shanoir-ng-front/src/app/subjects/subject-list/subject-list.component.ts
Outdated
Show resolved
Hide resolved
michaelkain
reviewed
Oct 21, 2024
shanoir-ng-front/src/app/shared/components/entity/entity.abstract.service.ts
Outdated
Show resolved
Hide resolved
michaelkain
reviewed
Oct 21, 2024
shanoir-ng-front/src/app/shared/components/entity/entity-list.component.abstract.ts
Outdated
Show resolved
Hide resolved
michaelkain
reviewed
Oct 22, 2024
shanoir-ng-front/src/app/subjects/subject-list/subject-list.component.ts
Outdated
Show resolved
Hide resolved
|
Also add a warning text that says "Deleting a subject will delete all its content (examination, acquisition, dataset)." |
michaelkain
reviewed
Oct 23, 2024
shanoir-ng-front/src/app/shared/components/entity/entity-list.component.abstract.ts
Show resolved
Hide resolved
michaelkain
reviewed
Oct 23, 2024
shanoir-ng-front/src/app/shared/components/entity/entity.abstract.service.ts
Show resolved
Hide resolved
|
Hi @pierrehenri-dauvergne, do you think you might solve the conflict please? Thank you, Michael |
michaelkain
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Open subject-list
Click on the delete button
The popup should display the studies in which the subject belong:
Do the same but not from the subject-list but from a view with a tree:
