Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use to_h #7

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Don't use to_h #7

merged 4 commits into from
Jun 24, 2024

Conversation

dorner
Copy link
Member

@dorner dorner commented Jun 24, 2024

This wasn't using to_json on the actual request object, so it didn't do nice things like formatting Google Timestamps the way they should be.

Copy link
Contributor

@nkadovic nkadovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dorner dorner merged commit 0ee2838 into main Jun 24, 2024
3 checks passed
@dorner dorner deleted the fix-date-format branch June 24, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants