Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MFKey to v3.0 #243

Draft
wants to merge 17 commits into
base: dev
Choose a base branch
from
Draft

Update MFKey to v3.0 #243

wants to merge 17 commits into from

Conversation

noproto
Copy link
Contributor

@noproto noproto commented Sep 18, 2024

What's new

This pull request only serves to track changes (as the source may be relocated for OFW 1.1).

  • Added Static Encrypted Nested key recovery
  • Added NFC app support
  • Dropped FlipperNested support

Verification

Using PR 3822: flipperdevices/flipperzero-firmware#3822

  • Acquire weak PRNG MIFARE Classic tag with unknown keys.
  • Open NFC app.
  • Select "Read" and hold the Flipper Zero against the tag. Wait until tag is fully read.
  • Open MFKey manually/select "Recover keys" in NFC app.
  • Press center button on Flipper to initiate key recovery. New keys must be found in this step.
  • Return to NFC app and select "Read". Wait until tag is fully read.
  • Confirm all keys are found on tag.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@noproto noproto marked this pull request as ready for review September 21, 2024 15:27
@noproto noproto marked this pull request as draft September 21, 2024 16:02
@noproto noproto marked this pull request as ready for review September 23, 2024 23:14
@noproto
Copy link
Contributor Author

noproto commented Sep 24, 2024

Reviewing PR to PR branch noproto#1 Merged.

@noproto
Copy link
Contributor Author

noproto commented Oct 9, 2024

@skotopes
Copy link
Member

I'm a little confused.

Where will be main repository for this application? Here? Firmware? Your repository?

From firmware standpoint the best place is main firmware repository, but we also can have it as submodule.

@skotopes skotopes marked this pull request as draft October 14, 2024 19:55
@skotopes
Copy link
Member

I'll put it into draft mode since APIs needed for this app is missing

@noproto
Copy link
Contributor Author

noproto commented Oct 15, 2024

I'm a little confused.

Where will be main repository for this application? Here? Firmware? Your repository?

From firmware standpoint the best place is main firmware repository, but we also can have it as submodule.

Firmware. I opened this PR when the changes were being developed in case there was feedback, it could be discussed here. Now that flipperdevices/flipperzero-firmware#3943 is open, development has moved there. If and when 3943 is merged, mfkey can be deleted from the good-faps repository and the catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants