Fix process killing on modern java versions (using PID API introduced…

… in Java 9 instead of reflection that's no longer allowed). Fixes #207

CHANGELOG.md

@@ -4,6 +4,12 @@ This changelog contains a loose collection of changes in every release. I will a
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to a "shifted" version of semantic versioning while the major version remains at 0: Minor version changes indicate breaking changes, patch version changes should not contain breaking changes.
 
+## 0.14.7
+
+### Fixed
+
+* Fix process killing that did not work in modern Java versions (#207)
+
 ## 0.14.6
 
 ### Fixed

src/clj/lambdacd/steps/shell.clj

@@ -5,8 +5,7 @@
             [me.raynes.conch.low-level :as sh]
             [clojure.core.async :as async]
             [lambdacd.util.internal.temp :as temp-util]
-            [lambdacd.stepsupport.output :as output]
-            [lambdacd.util.internal.reflection :as reflection-util])
+            [lambdacd.stepsupport.output :as output])
   (:import (java.util UUID)
            (java.io IOException)
            (com.jezhumble.javasysmon JavaSysMon)))
@@ -18,11 +17,8 @@
     (zero? exit-code) :success
     :default :failure))
 
-(defn- pid-of-process [proc]
-  (reflection-util/private-field proc "pid"))
-
 (defn- kill [was-killed-indicator proc ctx]
-  (let [pid (pid-of-process proc)]
+  (let [pid (.pid proc)]
     (reset! was-killed-indicator true)
     (async/>!! (:result-channel ctx) [:processed-kill true])
     (.destroy proc)