feat(out_kafka2): adds support for AWS IAM authentication to MSK usin… #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raytung
force-pushed
the
feat/aws-iam-auth
branch
from
fae0066
to
9fe4e47
Compare
…g long lived credentials This commit adds support for AWS IAM authentication using long lived credentials (access key id and secret access keys). To support AWS assume role and STS, we will need to wait for upstream's `ruby-kafka` library support. We will need to bump `ruby-kafka` to 1.5.0 in order to support this feature. Signed-off-by: Ray Tung <[email protected]>
raytung
force-pushed
the
feat/aws-iam-auth
branch
from
9fe4e47
to
c7fce94
Compare
|
It's not this PR's problem but I think it would be better to unify indent & setting mandatory parameters. |
BTW according to https://github.com/zendesk/ruby-kafka ruby-kafka is no longer maintained. |
|
@ashie I saw that too 😢 I spent a bit of time digging up the story for librdkafka but it looks like there's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g long lived credentials
Addresses #472
This PR adds support for AWS IAM authentication using long lived credentials (access key id and secret access keys). To support AWS assume role and STS, we will need to wait for upstream's
ruby-kafkalibrary support.We will need to bump
ruby-kafkato 1.5.0 in order to support this feature.