windows: fix gem: --no-document in gemrc #398

kenhys · 2024-09-13T06:48:32Z

In the previous versions, append gem: --no-document for c:\ProgramData\gemrc, but it does not work as expected because the default gemrc content is different as we thought.

So, we should override explicitly by gem: --no-document here.

Checked with installing json gem about this behavior.

  C:\>type c:\ProgramData\gemrc
  # This is the system wide config file for Rubygems.
  # It is generated by RubyInstaller as a security measure.
  # Feel free to add any rubygems config options as described on:
  #    https://docs.ruby-lang.org/en/3.1/Gem/ConfigFile.html
  # But do not delete this file as otherwise it could be hijacked by
  # another user in a multi-user environment.
  ---
  {}
  gem: --no-document

  C:\>echo gem: --no-document > c:\ProgramData\gemrc

  C:\>type c:\ProgramData\gemrc
  gem: --no-document

  C:\>gem install json
  Fetching json-2.7.2.gem
  Temporarily enhancing PATH for MSYS/MINGW...
  Building native extensions. This could take a while...
  Successfully installed json-2.7.2
  1 gem installed

kenhys · 2024-09-13T06:49:50Z

TIPS: c:\ProgramData\gemrc was generated by ridk install 3.

kenhys · 2024-09-13T06:55:59Z

Before: ri documentation was installed unexpectedly

https://github.com/fluent/fluentd-docker-image/actions/runs/10843478819/job/30090722070

kenhys · 2024-09-13T07:05:43Z

install: --no-document might be better.

kenhys · 2024-09-13T07:22:09Z

Hmm, update: --no-document too.

kenhys · 2024-09-13T07:38:48Z

https://github.com/fluent/fluentd-docker-image/actions/runs/10844861419/job/30094542725?pr=398

gemrcの修正で期待通りri installされなくなった

Building native extensions. This could take a while...
Successfully installed oj-3.16.5
1 gem installed
Temporarily enhancing PATH for MSYS/MINGW...
Building native extensions. This could take a while...
Successfully installed json-2.7.2
1 gem installed
Successfully installed rexml-3.3.5
1 gem installed
Temporarily enhancing PATH for MSYS/MINGW...
Building native extensions. This could take a while...
Successfully installed yajl-ruby-1.4.3
Successfully installed ffi-1.17.0-x64-mingw-ucrt
Successfully installed ffi-win32-extensions-1.0.4
Successfully installed win32-service-2.3.2
Successfully installed win32-ipc-0.7.0
Successfully installed win32-event-0.6.3
Successfully installed webrick-1.8.1
Successfully installed concurrent-ruby-1.3.4
Successfully installed tzinfo-2.0.6
Successfully installed tzinfo-data-1.2024.2
Building native extensions. This could take a while...
Successfully installed strptime-0.2.5
Successfully installed sigdump-0.2.5
Successfully installed serverengine-2.3.2
Building native extensions. This could take a while...
Successfully installed msgpack-1.7.2
Successfully installed logger-1.6.1
Building native extensions. This could take a while...
Successfully installed http_parser.rb-0.8.0
Successfully installed drb-2.2.1
Building native extensions. This could take a while...
Successfully installed cool.io-1.8.1
Building native extensions. This could take a while...
Successfully installed certstore_c-0.1.7
Successfully installed base64-0.2.0
Successfully installed fluentd-1.17.1-x64-mingw-ucrt
21 gems installed
Successfully installed win32-service-2.3.2
1 gem installed
Successfully installed win32-ipc-0.7.0
1 gem installed
Successfully installed win32-event-0.6.3
1 gem installed

kenhys · 2024-09-13T07:40:07Z

ridk install 3が生成するgemrcの既定値が今後変わって問題になるようならそのときまた考えればいいだろう。

daipom · 2024-09-13T08:09:49Z

I see.
I am concerned about whether it is safe to overwrite it.
This file should not be editable except for a specific user.
Can overwriting this file change the permissions?

I asked rubyinstaller2 about this point.

Questions about automatic "system gemrc" file creation oneclick/rubyinstaller2#388

kenhys · 2024-09-17T01:10:51Z

I'll fix it a bit.

In the previous versions, append gem: --no-document for c:\ProgramData\gemrc, but it does not work as expected because the default gemrc content is different as we thought. So, we should override explicitly by gem: --no-document here. C:\>type c:\ProgramData\gemrc # This is the system wide config file for Rubygems. # It is generated by RubyInstaller as a security measure. # Feel free to add any rubygems config options as described on: # https://docs.ruby-lang.org/en/3.1/Gem/ConfigFile.html # But do not delete this file as otherwise it could be hijacked by # another user in a multi-user environment. --- {} gem: --no-document C:\>echo gem: --no-document > c:\ProgramData\gemrc C:\>type c:\ProgramData\gemrc gem: --no-document C:\>gem install json Fetching json-2.7.2.gem Temporarily enhancing PATH for MSYS/MINGW... Building native extensions. This could take a while... Successfully installed json-2.7.2 1 gem installed Signed-off-by: Kentaro Hayashi <[email protected]>

kenhys · 2024-09-17T05:31:34Z

ridk install 3が生成するgemrcの既定値が今後変わって問題になるようならそのときまた考えればいいだろう。

changed to use ruby's one-liner script to replace it.

It will be safe even though the default gemrc was changed by ridk.

daipom · 2024-09-17T08:24:19Z

I see. I am concerned about whether it is safe to overwrite it. This file should not be editable except for a specific user. Can overwriting this file change the permissions?

I asked rubyinstaller2 about this point.
* [Questions about automatic "system gemrc" file creation oneclick/rubyinstaller2#388](https://github.com/oneclick/rubyinstaller2/issues/388)

Just to be sure, I have confirmed that overwriting the file doesn't change the ACL.

Powershell with administrative privilege

> cp C:\ProgramData\gemrc C:\ProgramData\gemrc.cp
> Set-Acl C:\ProgramData\gemrc.cp -AclObject (Get-Acl C:\ProgramData\gemrc)
> Get-Acl .\gemrc.cp | Format-List Owner,Group,AccessToString


Owner          : NT AUTHORITY\SYSTEM
Group          : NT AUTHORITY\SYSTEM
AccessToString : NT AUTHORITY\SYSTEM Allow  FullControl
                 BUILTIN\Administrators Allow  FullControl
                 BUILTIN\Users Allow  ReadAndExecute, Synchronize

Command Prompt with administrative privilege

echo gem: --no-document > \ProgramData\gemrc.cp

Powershell with administrative privilege

> Get-Acl .\gemrc.cp | Format-List Owner,Group,AccessToString


Owner          : NT AUTHORITY\SYSTEM
Group          : NT AUTHORITY\SYSTEM
AccessToString : NT AUTHORITY\SYSTEM Allow  FullControl
                 BUILTIN\Administrators Allow  FullControl
                 BUILTIN\Users Allow  ReadAndExecute, Synchronize

Dockerfile.template.erb

daipom · 2024-09-17T08:49:17Z

Just to be sure, I have confirmed that overwriting the file doesn't change the ACL.

I have confirmed it is the same when using Ruby.

daipom

LGTM! Thanks for this!
Please regenerate Dockerfiles.

Co-authored-by: Daijiro Fukuda <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>

Signed-off-by: Kentaro Hayashi <[email protected]>

kenhys · 2024-09-18T01:25:51Z

Please regenerate Dockerfiles.

I've forgot it to do so....

kenhys force-pushed the drop-ri branch from 5479960 to 2edaeba Compare September 13, 2024 07:04

kenhys force-pushed the drop-ri branch from 2edaeba to 2a62749 Compare September 13, 2024 07:21

kenhys requested a review from daipom September 13, 2024 07:40

kenhys force-pushed the drop-ri branch from 4c51e0a to 00408ad Compare September 17, 2024 05:30

daipom mentioned this pull request Sep 17, 2024

Questions about automatic "system gemrc" file creation oneclick/rubyinstaller2#388

Closed

daipom reviewed Sep 17, 2024

View reviewed changes

Dockerfile.template.erb Outdated Show resolved Hide resolved

kenhys force-pushed the drop-ri branch from 8cf4244 to 08d0069 Compare September 17, 2024 08:48

daipom approved these changes Sep 17, 2024

View reviewed changes

kenhys and others added 2 commits September 18, 2024 10:24

Update Dockerfile.template.erb

263a7ce

Co-authored-by: Daijiro Fukuda <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>

Re-generate Dockerfile

fe55631

Signed-off-by: Kentaro Hayashi <[email protected]>

kenhys force-pushed the drop-ri branch from 08d0069 to fe55631 Compare September 18, 2024 01:25

kenhys merged commit a528078 into fluent:master Sep 18, 2024
5 checks passed

kenhys deleted the drop-ri branch September 18, 2024 02:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

windows: fix gem: --no-document in gemrc #398

windows: fix gem: --no-document in gemrc #398

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024 •

edited

Loading

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

daipom commented Sep 13, 2024

kenhys commented Sep 17, 2024

kenhys commented Sep 17, 2024 •

edited

Loading

daipom commented Sep 17, 2024

daipom commented Sep 17, 2024

daipom left a comment

kenhys commented Sep 18, 2024

windows: fix gem: --no-document in gemrc #398

windows: fix gem: --no-document in gemrc #398

Conversation

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024 • edited Loading

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

kenhys commented Sep 13, 2024

daipom commented Sep 13, 2024

kenhys commented Sep 17, 2024

kenhys commented Sep 17, 2024 • edited Loading

daipom commented Sep 17, 2024

daipom commented Sep 17, 2024

daipom left a comment

Choose a reason for hiding this comment

kenhys commented Sep 18, 2024

kenhys commented Sep 13, 2024 •

edited

Loading

kenhys commented Sep 17, 2024 •

edited

Loading