Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to New Relic #421

Open
wants to merge 1 commit into
base: 1.0
Choose a base branch
from
Open

Conversation

smamindla57
Copy link

Hey,
We have many users on our platform who are using Fluentd and would like to instrument it. We’d love to provide a smooth experience for Fluentd users who need to use commercial monitoring solutions. Please see our documentation here.

Please consider adding a link for your direct users to provide an option for New Relic. We propose the content submitted in this PR.

@ashie
Copy link
Member

ashie commented Aug 9, 2022

Thanks for your proposal!
The change itself looks good to me.

Could you resolve failed check?
https://github.com/fluent/fluentd-docs-gitbook/pull/421/checks?check_run_id=7739971054
Just add Signed-off-by field to your commit message by following command:

$ git rebase HEAD~1 --signoff
$ git push -f origin patch-1

Signed-off-by: smamindla57 <[email protected]>
@smamindla57
Copy link
Author

Hi @ashie,
Thank you for your response. I have resolved the issue which you have mentioned. Please review again and let me know if there are any concerns.
Thank you!

@smamindla57
Copy link
Author

Hi @ashie ,
Please let me know any update on this?

@ashie
Copy link
Member

ashie commented Sep 27, 2022

Sorry for the delay.
Now I've noticed that adding New Relic here doesn't seem appropriate since this part is about Metrics Monitoring.
The link you added here doesn't seem contain the topic for Metrics, just sending logs: https://docs.newrelic.com/docs/logs/forward-logs/fluentd-plugin-log-forwarding/
I don't object adding a link to New Relic but probably there is some other more suitable place to add.
Or do have you a page to describe about metrics?

@ashie ashie changed the title Update overview.md Add a link to New Relic Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants