Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fluent-bit): Updated image to v3.1.10 #565

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

edsiper
Copy link
Member

@edsiper edsiper commented Nov 5, 2024

The following PR updates the Fluent Bit image to the latest version available: v3.1.10:

In addition, I am reverting the change that was done in the PullPolicy for the main image from 'IfNotPresent' to 'Always'. As you know, we don't do user-telemetry in Fluent Bit, our only indicator of adoption is the number of deployments/downloads from the containers registry. Users can always tweak this value, so I am just changing the default as the one we had before.

The following PR updates the Fluent Bit image to the latest version
available: v3.1.10.

In addition, I am reverting the change that was done in the PullPolicy
for the main image from 'IfNotPresent' to 'Always'. As you know, we
don't do user-telemetry in Fluent Bit, our only indicator of adoption
is the number of deployments/downloads from the containers registry.
Users can always tweak this value, so I am just changing the default.

Signed-off-by: Eduardo Silva <[email protected]>
@edsiper edsiper merged commit 83176e0 into main Nov 5, 2024
2 checks passed
@edsiper edsiper deleted the update-fluent-bit-3.1.10 branch November 5, 2024 03:03
@stevehipwell
Copy link
Collaborator

@edsiper changing the pull policy like this is a major issue given that the image is hosted on Docker Hub where the rate limit is aggressively low. Also given the vanity OCI registry needs explicitly authenticating with Docker credentials even clusters with Docker auth configured correctly make be impacted. I'm speaking from experience here.

Also I can't see a valid use case for this being required to get a correct usage for FB? If the image hasn't changed and it still exists on the node then the only change was a configuration one and shouldn't add another "download".

@edsiper
Copy link
Member Author

edsiper commented Nov 5, 2024

@stevehipwell the main reason to bring that value Always back is pretty much to revert the change that was done in April this year in this commit. For years we set to Always as a mechanism to measure Fluent Bit adoption in containerized environments, since that change we lost the metrics, and I think this is the less invasive than adding user-telemetry in the project.

Just reverting to what was working from a maintainers/ecosystem perspective until we have a better solution, anyways this can be easily changed by the user.

@stevehipwell
Copy link
Collaborator

@edsiper that setting was a hangover from when the image version wasn't immutable (e.g. latest), when it was required. If the download numbers changed after this change it just means that the numbers were never correct; index pulls do not equal downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants