Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-setup master when master role restarted or recreated and recover dataset #3383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: re-setup master when master role restarted or recreated and recover dataset #3383

wants to merge 1 commit into from

Conversation

SimonCqk
Copy link
Contributor

@SimonCqk SimonCqk commented Aug 7, 2023 •
edited
Loading

Ⅰ. Describe what this PR does

fix #3368

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

see /pkg/ctrl/master_test.go

Ⅳ. Describe how to verify it

  1. apply a brand new JindoFS cache cluster and wait all pods ready
  2. delete jindo master pod and wait it running
  3. exec into jindo master and execute jindo admin -mount, check oss mountpoint has been re-mounted or not from stdout.

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ronggu for approval by writing /assign @ronggu in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Aug 7, 2023

Hi @SimonCqk. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SimonCqk SimonCqk changed the title feat: re-setup master when master role restarted or recreated and rec… feat: re-setup master when master role restarted or recreated and recover dataset Aug 7, 2023
@frankleaf
Copy link
Member

I think we can do this during entrypoint startup, when master pod recreate or transfer to other node, we can use entrypoint script to recover mount point

@cheyang cheyang requested a review from frankleaf August 10, 2023 01:55
cheyang
cheyang reviewed Aug 10, 2023
View reviewed changes
pkg/ddc/jindo/health_check.go Outdated
)

func (e *JindoEngine) CheckRuntimeHealthy() (err error) {
e.Log.V(3).Info("CheckRuntimeHealthy", "runtime name", e.runtimeInfo.GetName())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V(3) -> V(1). It's because the current log system only supports production or debug level. V(1) indicates debug level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@cheyang
Copy link
Collaborator

cheyang commented Aug 18, 2023

@SimonCqk please fix the source code check, thanks.

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
9.8% 9.8% Duplication

@SimonCqk
Copy link
Contributor Author

@SimonCqk please fix the source code check, thanks.

done :)

cheyang
cheyang reviewed Sep 6, 2023
View reviewed changes
pkg/utils/patch/patch_utils.go
@@ -0,0 +1,155 @@
package patch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add license header. Thanks.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
19.8% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.4% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheyang cheyang cheyang left review comments

@frankleaf frankleaf Awaiting requested review from frankleaf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] JindoMaster mount point did not recovered from pod migration.
3 participants
@SimonCqk @frankleaf @cheyang